Удалить машину можно в любом состоянии: работающая выключается, пока идёт задача удаление ждёт, пробросы портов машины удаляются вместе с ней

tests/test_audit_fixes.py

@@ -1,7 +1,7 @@
 """Regressions for the defects found by the 0.11 audit."""
 import json
 from pathlib import Path
-from urllib.parse import quote
+from urllib.parse import quote, unquote
 
 import app
 import conftest
@@ -69,6 +69,46 @@ def test_vm_delete_failure_is_reported(logged_in, data_dirs, monkeypatch):
     assert response.headers["location"].startswith("/vm/web01?error=")
 
 
+def test_vm_delete_stops_paused_machine_first(logged_in, data_dirs, monkeypatch):
+    import core
+
+    calls = recording(monkeypatch, app)
+    recording(monkeypatch, core, [(["virsh", "domstate"], conftest.fake_result("paused"))])
+    logged_in.post("/vm/web01/delete", follow_redirects=False)
+    assert find(calls, "virsh", "destroy", "web01") and find(calls, "virsh", "undefine", "web01")
+
+
+def test_vm_delete_waits_for_running_task(logged_in, data_dirs, monkeypatch):
+    import core
+
+    calls = recording(monkeypatch, app)
+    backup = core.new_operation("backup", "Резервная копия web01", vm_name="web01")
+    core.update_operation(backup, status="running")
+    response = logged_in.post("/vm/web01/delete", follow_redirects=False)
+    assert "Резервная копия web01" in unquote(response.headers["location"])
+    assert not find(calls, "virsh", "undefine") and not find(calls, "virsh", "destroy")
+
+
+def test_vm_delete_removes_its_port_forwards(logged_in, data_dirs, monkeypatch):
+    recording(monkeypatch, app)
+    rule = {"guest_ip": "192.168.100.51", "external_port_start": 2222, "external_port_end": 2222, "guest_port_start": 22, "guest_port_end": 22, "protocol": "tcp"}
+    data_dirs["network"].joinpath("port_forwards.json").write_text(json.dumps([
+        {"id": "1", "vm_name": "web01", **rule},
+        {"id": "2", "vm_name": "db01", **rule, "external_port_start": 2223, "external_port_end": 2223, "guest_ip": "192.168.100.52"},
+    ]))
+    response = logged_in.post("/vm/web01/delete", follow_redirects=False)
+    assert "убраны пробросы портов: 1" in unquote(response.headers["location"])
+    assert [item["vm_name"] for item in network_core.load_port_forwards()] == ["db01"]
+    assert "2222" not in (data_dirs["nft"] / "virtuality.nft").read_text()
+
+
+def test_delete_is_offered_for_running_machine(logged_in):
+    html = logged_in.get("/vm/web01").text  # в тестах web01 работает
+    assert 'action="/vm/web01/delete"' in html and "она будет сразу выключена" in html
+    dashboard = logged_in.get("/").text
+    assert 'action="/vm/web01/delete"' in dashboard and 'action="/vm/db01/delete"' in dashboard
+
+
 # ---------------------------------------------------------------- ISO in the CD-ROM drive (app.py:1150, 1158)
 def test_iso_mount_uses_change_media_for_existing_drive(logged_in, data_dirs, monkeypatch):
     iso = data_dirs["iso"] / "debian.iso"