Update project and tests

app/build.gradle

@@ -4,25 +4,27 @@ android {
     compileSdkVersion 29
 
     defaultConfig {
-        applicationId "org.traccar.client"
-        buildConfigField "boolean", "HIDDEN_APP", "false"
+        applicationId 'org.traccar.client'
+        buildConfigField 'boolean', 'HIDDEN_APP', 'false'
         minSdkVersion 16
         targetSdkVersion 29
-        versionCode 61
-        versionName '6.0'
+        versionCode 64
+        versionName '6.3'
     }
 
     lintOptions {
         checkReleaseBuilds false
     }
 
-    flavorDimensions "default"
+    flavorDimensions 'default'
     productFlavors {
-        regular
+        regular {
+            isDefault.set(true)
+        }
         google
         hidden {
-            applicationId "org.traccar.client.hidden"
-            buildConfigField "boolean", "HIDDEN_APP", "true"
+            applicationId 'org.traccar.client.hidden'
+            buildConfigField 'boolean', 'HIDDEN_APP', 'true'
         }
     }
 
@@ -34,18 +36,19 @@ android {
 }
 
 dependencies {
-    implementation 'com.google.android.material:material:1.1.0-alpha10'
-    implementation 'androidx.preference:preference:1.1.0'
-    testImplementation 'junit:junit:4.12'
+    implementation 'com.google.android.material:material:1.3.0-alpha01'
+    implementation 'androidx.preference:preference:1.1.1'
+    testImplementation 'junit:junit:4.13'
     testImplementation 'org.robolectric:robolectric:4.1'
-    googleImplementation 'com.google.firebase:firebase-core:17.2.0'
+    googleImplementation 'com.google.firebase:firebase-core:17.4.3'
     googleImplementation 'com.crashlytics.sdk.android:crashlytics:2.10.1'
-    googleImplementation "com.google.android.gms:play-services-location:17.0.0"
+    googleImplementation 'com.google.firebase:firebase-analytics:17.4.3'
+    googleImplementation 'com.google.android.gms:play-services-location:17.0.0'
 }
 
-if (getGradle().getStartParameter().getTaskRequests().toString().contains("Google")) {
+if (getGradle().getStartParameter().getTaskRequests().toString().contains('Google')) {
     apply plugin: 'com.google.gms.google-services'
-    apply plugin: 'io.fabric'
+    apply plugin: 'com.google.firebase.crashlytics'
 
     task copyJson(type: Copy) {
         from '../../traccar-shared/google-services'

app/src/main/java/org/traccar/client/MainFragment.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2012 - 2019 Anton Tananaev (anton@traccar.org)
+ * Copyright 2012 - 2020 Anton Tananaev (anton@traccar.org)
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -27,22 +27,27 @@ import android.content.pm.PackageManager;
 import android.net.Uri;
 import android.os.Build;
 import android.os.Bundle;
+import android.text.InputType;
+import android.util.Log;
+import android.view.Menu;
+import android.view.MenuInflater;
+import android.view.MenuItem;
+import android.view.View;
+import android.webkit.URLUtil;
+import android.widget.EditText;
+import android.widget.Toast;
+
 import androidx.annotation.NonNull;
-import androidx.core.content.ContextCompat;
 import androidx.appcompat.app.AlertDialog;
+import androidx.core.content.ContextCompat;
 import androidx.preference.EditTextPreference;
+import androidx.preference.EditTextPreferenceDialogFragmentCompat;
 import androidx.preference.Preference;
 import androidx.preference.PreferenceFragmentCompat;
 import androidx.preference.PreferenceManager;
 import androidx.preference.TwoStatePreference;
 
-import android.util.Log;
-import android.view.Menu;
-import android.view.MenuInflater;
-import android.view.MenuItem;
-import android.webkit.URLUtil;
-import android.widget.Toast;
-
+import java.util.Arrays;
 import java.util.HashSet;
 import java.util.Random;
 import java.util.Set;
@@ -60,6 +65,7 @@ public class MainFragment extends PreferenceFragmentCompat implements OnSharedPr
     public static final String KEY_ANGLE = "angle";
     public static final String KEY_ACCURACY = "accuracy";
     public static final String KEY_STATUS = "status";
+    public static final String KEY_BUFFER = "buffer";
 
     private static final int PERMISSIONS_REQUEST_LOCATION = 2;
 
@@ -134,6 +140,36 @@ public class MainFragment extends PreferenceFragmentCompat implements OnSharedPr
 
     }
 
+    public static class NumericEditTextPreferenceDialogFragment extends EditTextPreferenceDialogFragmentCompat {
+
+        public static NumericEditTextPreferenceDialogFragment newInstance(String key) {
+            final NumericEditTextPreferenceDialogFragment fragment = new NumericEditTextPreferenceDialogFragment();
+            final Bundle bundle = new Bundle();
+            bundle.putString(ARG_KEY, key);
+            fragment.setArguments(bundle);
+            return fragment;
+        }
+
+        @Override
+        protected void onBindDialogView(View view) {
+            EditText editText = view.findViewById(android.R.id.edit);
+            editText.setInputType(InputType.TYPE_CLASS_NUMBER);
+            super.onBindDialogView(view);
+        }
+
+    }
+
+    @Override
+    public void onDisplayPreferenceDialog(Preference preference) {
+        if (Arrays.asList(KEY_INTERVAL, KEY_DISTANCE, KEY_ANGLE).contains(preference.getKey())) {
+            final EditTextPreferenceDialogFragmentCompat f = NumericEditTextPreferenceDialogFragment.newInstance(preference.getKey());
+            f.setTargetFragment(this, 0);
+            f.show(getFragmentManager(), "androidx.preference.PreferenceFragment.DIALOG");
+        } else {
+            super.onDisplayPreferenceDialog(preference);
+        }
+    }
+
     private void removeLauncherIcon() {
         String className = MainActivity.class.getCanonicalName().replace(".MainActivity", ".Launcher");
         ComponentName componentName = new ComponentName(getActivity().getPackageName(), className);
@@ -169,6 +205,7 @@ public class MainFragment extends PreferenceFragmentCompat implements OnSharedPr
         findPreference(KEY_DISTANCE).setEnabled(enabled);
         findPreference(KEY_ANGLE).setEnabled(enabled);
         findPreference(KEY_ACCURACY).setEnabled(enabled);
+        findPreference(KEY_BUFFER).setEnabled(enabled);
     }
 
     @Override

app/src/main/java/org/traccar/client/TrackingController.java

@@ -35,6 +35,7 @@ public class TrackingController implements PositionProvider.PositionListener, Ne
     private SharedPreferences preferences;
 
     private String url;
+    private boolean buffer;
 
     private PositionProvider positionProvider;
     private DatabaseHelper databaseHelper;
@@ -50,6 +51,7 @@ public class TrackingController implements PositionProvider.PositionListener, Ne
         isOnline = networkManager.isOnline();
 
         url = preferences.getString(MainFragment.KEY_URL, context.getString(R.string.settings_url_default_value));
+        buffer = preferences.getBoolean(MainFragment.KEY_BUFFER, true);
     }
 
     public void start() {
@@ -78,7 +80,11 @@ public class TrackingController implements PositionProvider.PositionListener, Ne
     public void onPositionUpdate(Position position) {
         StatusActivity.addMessage(context.getString(R.string.status_location_update));
         if (position != null) {
-            write(position);
+            if (buffer) {
+                write(position);
+            } else {
+                send(position);
+            }
         }
     }
 
@@ -173,10 +179,14 @@ public class TrackingController implements PositionProvider.PositionListener, Ne
             @Override
             public void onComplete(boolean success) {
                 if (success) {
-                    delete(position);
+                    if (buffer) {
+                        delete(position);
+                    }
                 } else {
                     StatusActivity.addMessage(context.getString(R.string.status_send_fail));
-                    retry();
+                    if (buffer) {
+                        retry();
+                    }
                 }
             }
         });

app/src/main/res/values-af/strings.xml

@@ -0,0 +1,46 @@
+<?xml version='1.0' encoding='UTF-8'?>
+<resources>
+  <string name="app_name">Traccar-kliënt</string>
+  <string name="app_logo">Traccar</string>
+  <string name="shortcut_start">Begin diens</string>
+  <string name="shortcut_stop">Stop diens</string>
+  <string name="shortcut_sos">Stuur SOS</string>
+  <string name="channel_default">Primêre Kanaal</string>
+  <string name="settings_id_title">Toestel-identifiseerder</string>
+  <string name="settings_url_title">Bediener-URL</string>
+  <string name="settings_url_summary">Volg bediener-URL</string>
+  <string name="settings_interval_title">Frekwensie</string>
+  <string name="settings_interval_summary">Rapporteer interval in sekondes</string>
+  <string name="settings_distance_title">Afstand</string>
+  <string name="settings_distance_summary">Rapporteer afstand in meter</string>
+  <string name="settings_angle_title">Hoek</string>
+  <string name="settings_angle_summary">Rapporteringshoek in grade</string>
+  <string name="settings_status_title">Diensstatus</string>
+  <string name="settings_status_off">Begin</string>
+  <string name="settings_status_on">Stop</string>
+  <string name="settings_status_off_summary">Diens gestop</string>
+  <string name="settings_status_on_summary">Diens loop</string>
+  <string name="settings_buffer">Vanlyn buffer</string>
+  <string name="settings_buffer_off_summary">Buffer af</string>
+  <string name="settings_buffer_on_summary">Buffer aan</string>
+  <string name="settings_accuracy_title">Ligging akkuraatheid</string>
+  <string name="settings_accuracy_summary">Verlangde ligging akkuraatheid</string>
+  <string name="settings_accuracy_high">Hoog</string>
+  <string name="settings_accuracy_medium">Medium</string>
+  <string name="settings_accuracy_low">Laag</string>
+  <string name="settings_foreground_title">Voorgrond diens</string>
+  <string name="settings_foreground_summary">Verhoog diensprioriteit</string>
+  <string name="menu_status">Status</string>
+  <string name="menu_shortcuts">Voeg kortpaaie by</string>
+  <string name="menu_clear">Skoonmaak</string>
+  <string name="status_service_create">Diens het begin</string>
+  <string name="status_service_destroy">Diens het gestop</string>
+  <string name="status_send_success">Stuur suksesvol</string>
+  <string name="status_send_fail">Stuur misluk</string>
+  <string name="status_location_update">Ligging opdateer</string>
+  <string name="status_network_online">Netwerk aanlyn</string>
+  <string name="status_network_offline">Netwerk vanlyn</string>
+  <string name="hidden_app_name">Toestelinstellings</string>
+  <string name="hidden_alert">Die toep is versteek. Skakel 8722227 (TRACCAR) om dit weer oop te maak.</string>
+  <string name="error_msg_invalid_url">Voer \'n geldige http: // of https: // URL in</string>
+</resources>

app/src/main/res/values-fi/strings.xml

@@ -20,6 +20,9 @@
   <string name="settings_status_on">Pysäytä</string>
   <string name="settings_status_off_summary">Palvelu pysäytetty</string>
   <string name="settings_status_on_summary">Palvelu käynnissä</string>
+  <string name="settings_buffer">Offline-puskurointi</string>
+  <string name="settings_buffer_off_summary">Puskurointi pois päältä</string>
+  <string name="settings_buffer_on_summary">Puskurointi päälle</string>
   <string name="settings_accuracy_title">Sijainnin tarkkuus</string>
   <string name="settings_accuracy_summary">Haluttu sijainnin tarkkuus</string>
   <string name="settings_accuracy_high">Korkea</string>

app/src/main/res/values-iw/strings.xml

@@ -0,0 +1,43 @@
+<?xml version='1.0' encoding='UTF-8'?>
+<resources>
+  <string name="app_name"> Traccar לאנדרויד</string>
+  <string name="app_logo">Traccar</string>
+  <string name="shortcut_start">הפעל שירות </string>
+  <string name="shortcut_stop">עצור תהליך</string>
+  <string name="shortcut_sos">שלח הודעת חירום</string>
+  <string name="channel_default">ערוץ ראשי</string>
+  <string name="settings_id_title">מזהה מכשיר</string>
+  <string name="settings_url_title">כתובת שרת</string>
+  <string name="settings_url_summary">כתובת שרת איתור</string>
+  <string name="settings_interval_title">תדירות</string>
+  <string name="settings_interval_summary">זמן דיווח בשניות </string>
+  <string name="settings_distance_title">מרחק</string>
+  <string name="settings_distance_summary">דיווח מרחק במטרים</string>
+  <string name="settings_angle_title">זווית</string>
+  <string name="settings_angle_summary">דיווח פניות בזווית </string>
+  <string name="settings_status_title">מצב שירות</string>
+  <string name="settings_status_off">הפעל</string>
+  <string name="settings_status_on">עצור</string>
+  <string name="settings_status_off_summary">השירות הופסק</string>
+  <string name="settings_status_on_summary">השירות פועל</string>
+  <string name="settings_accuracy_title">דיוק מיקום</string>
+  <string name="settings_accuracy_summary">דיוק מיקום מבוקש</string>
+  <string name="settings_accuracy_high">מדוייק </string>
+  <string name="settings_accuracy_medium">בינוני</string>
+  <string name="settings_accuracy_low">נמוך - משתמש רק בGPS של המכשיר </string>
+  <string name="settings_foreground_title">אפשר הפעלה ברקע</string>
+  <string name="settings_foreground_summary">הגדל את עדיפות התוכנה</string>
+  <string name="menu_status">סטטוס</string>
+  <string name="menu_shortcuts">הוסף קיצור דרך</string>
+  <string name="menu_clear">נקה</string>
+  <string name="status_service_create">אפליקציה הופעלה</string>
+  <string name="status_service_destroy">אפליקציה הופסקה</string>
+  <string name="status_send_success">נשלח בהצלחה</string>
+  <string name="status_send_fail">שליחה נכשלה</string>
+  <string name="status_location_update">עדכון מיקום</string>
+  <string name="status_network_online">רשת באונליין </string>
+  <string name="status_network_offline">רשת מנותקת</string>
+  <string name="hidden_app_name">הגדרות המכשיר</string>
+  <string name="hidden_alert">האפליקציה הוסתרה. כדי לפתוח אותה שוב חייג בטלפון 8722227 (TRACCAR).</string>
+  <string name="error_msg_invalid_url">הזן כתובת חוקית  http:// או  https:// URL</string>
+</resources>

app/src/main/res/values-ja/strings.xml

@@ -20,6 +20,9 @@
   <string name="settings_status_on">停止</string>
   <string name="settings_status_off_summary">サービス停止中</string>
   <string name="settings_status_on_summary">サービス実行中</string>
+  <string name="settings_buffer">オフラインバッファリング</string>
+  <string name="settings_buffer_off_summary">バッファリング オフ</string>
+  <string name="settings_buffer_on_summary">バッファリング オン</string>
   <string name="settings_accuracy_title">位置情報の精度</string>
   <string name="settings_accuracy_summary">要求される位置情報の精度</string>
   <string name="settings_accuracy_high">高</string>

app/src/main/res/values-nb/strings.xml

@@ -20,6 +20,9 @@
   <string name="settings_status_on">Stopp</string>
   <string name="settings_status_off_summary">Tjenesten stoppet</string>
   <string name="settings_status_on_summary">Tjenesten kjører</string>
+  <string name="settings_buffer">Frakoblet mellomlagring</string>
+  <string name="settings_buffer_off_summary">Mellomlagring deaktivert</string>
+  <string name="settings_buffer_on_summary">Mellomlagring på</string>
   <string name="settings_accuracy_title">Posisjonsnøyaktighet</string>
   <string name="settings_accuracy_summary">Ønsket plasseringsnøyaktighet</string>
   <string name="settings_accuracy_high">Høy</string>

app/src/main/res/values-nn/strings.xml

@@ -20,6 +20,9 @@
   <string name="settings_status_on">Stopp</string>
   <string name="settings_status_off_summary">Teneste stoppa</string>
   <string name="settings_status_on_summary">Tenar køyrer</string>
+  <string name="settings_buffer">Fråkopla mellomlagring</string>
+  <string name="settings_buffer_off_summary">Mellomlagring deaktivert</string>
+  <string name="settings_buffer_on_summary">Mellomlagring på</string>
   <string name="settings_accuracy_title">Lokasjonsnøyaktighet</string>
   <string name="settings_accuracy_summary">Ønska lokasjonsnøyaktighet</string>
   <string name="settings_accuracy_high">Høg</string>

app/src/main/res/values-pl/strings.xml

@@ -20,6 +20,9 @@
   <string name="settings_status_on">Zatrzymaj</string>
   <string name="settings_status_off_summary">Usługa zatrzymana</string>
   <string name="settings_status_on_summary">Usługa uruchomiona</string>
+  <string name="settings_buffer">Buforowanie offline</string>
+  <string name="settings_buffer_off_summary">Buforowanie wył.</string>
+  <string name="settings_buffer_on_summary"> Buforowanie wł.</string>
   <string name="settings_accuracy_title">Dokładność lokalizacji</string>
   <string name="settings_accuracy_summary">Żądana dokładność lokalizacji</string>
   <string name="settings_accuracy_high">Wysoka</string>

app/src/main/res/values-pt-rBR/strings.xml

@@ -20,6 +20,9 @@
   <string name="settings_status_on">Parar</string>
   <string name="settings_status_off_summary">Serviço Parado</string>
   <string name="settings_status_on_summary">Serviço em execução</string>
+  <string name="settings_buffer">Offline buffering</string>
+  <string name="settings_buffer_off_summary">Buffering off</string>
+  <string name="settings_buffer_on_summary">Buffering on</string>
   <string name="settings_accuracy_title">Precisão de localização</string>
   <string name="settings_accuracy_summary">Precisão de localização desejada</string>
   <string name="settings_accuracy_high">Alto</string>

app/src/main/res/values/strings.xml

@@ -20,6 +20,9 @@
   <string name="settings_status_on">Stop</string>
   <string name="settings_status_off_summary">Service stopped</string>
   <string name="settings_status_on_summary">Service running</string>
+  <string name="settings_buffer">Offline buffering</string>
+  <string name="settings_buffer_off_summary">Buffering off</string>
+  <string name="settings_buffer_on_summary">Buffering on</string>
   <string name="settings_accuracy_title">Location accuracy</string>
   <string name="settings_accuracy_summary">Desired location accuracy</string>
   <string name="settings_accuracy_high">High</string>

app/src/main/res/xml/preferences.xml

@@ -31,22 +31,29 @@
     <EditTextPreference
         android:defaultValue="300"
         android:key="interval"
-        android:numeric="integer"
+        android:inputType="number"
         android:summary="@string/settings_interval_summary"
         android:title="@string/settings_interval_title" />
 
     <EditTextPreference
         android:defaultValue="0"
         android:key="distance"
-        android:numeric="integer"
+        android:inputType="number"
         android:summary="@string/settings_distance_summary"
         android:title="@string/settings_distance_title" />
 
     <EditTextPreference
         android:defaultValue="0"
         android:key="angle"
-        android:numeric="integer"
+        android:inputType="number"
         android:summary="@string/settings_angle_summary"
         android:title="@string/settings_angle_title" />
 
+    <CheckBoxPreference
+        android:defaultValue="true"
+        android:key="buffer"
+        android:summaryOff="@string/settings_buffer_off_summary"
+        android:summaryOn="@string/settings_buffer_on_summary"
+        android:title="@string/settings_buffer" />
+
 </PreferenceScreen>

app/src/test/java/org/traccar/client/DatabaseHelperTest.java

@@ -2,6 +2,7 @@
 package org.traccar.client;
 
 import android.location.Location;
+import android.os.Build;
 
 import org.junit.Test;
 import org.junit.runner.RunWith;
@@ -14,6 +15,7 @@ import java.util.Date;
 import static org.junit.Assert.assertNotNull;
 import static org.junit.Assert.assertNull;
 
+@Config(sdk = Build.VERSION_CODES.P)
 @RunWith(RobolectricTestRunner.class)
 public class DatabaseHelperTest {
 

app/src/test/java/org/traccar/client/ProtocolFormatterTest.java

@@ -2,6 +2,7 @@
 package org.traccar.client;
 
 import android.location.Location;
+import android.os.Build;
 
 import org.junit.Test;
 import org.junit.runner.RunWith;
@@ -12,6 +13,7 @@ import java.util.Date;
 
 import static org.junit.Assert.assertEquals;
 
+@Config(sdk = Build.VERSION_CODES.P)
 @RunWith(RobolectricTestRunner.class)
 public class ProtocolFormatterTest {
 

app/src/test/java/org/traccar/client/RequestManagerTest.java

@@ -1,6 +1,8 @@
 
 package org.traccar.client;
 
+import android.os.Build;
+
 import org.junit.Ignore;
 import org.junit.Test;
 import org.junit.runner.RunWith;
@@ -9,10 +11,11 @@ import org.robolectric.annotation.Config;
 
 import static org.junit.Assert.assertTrue;
 
+@Config(sdk = Build.VERSION_CODES.P)
 @RunWith(RobolectricTestRunner.class)
 public class RequestManagerTest {
 
-    @Ignore
+    @Ignore("Not a real unit test")
     @Test
     public void testSendRequest() throws Exception {
 

build.gradle

@@ -2,12 +2,11 @@ buildscript {
     repositories {
         google()
         jcenter()
-        maven { url 'https://maven.fabric.io/public' }
     }
     dependencies {
-        classpath 'com.android.tools.build:gradle:3.5.2'
-        classpath 'com.google.gms:google-services:4.3.2'
-        classpath 'io.fabric.tools:gradle:1.26.1'
+        classpath 'com.android.tools.build:gradle:4.0.0'
+        classpath 'com.google.gms:google-services:4.3.3'
+        classpath 'com.google.firebase:firebase-crashlytics-gradle:2.1.1'
     }
 }
 

gradle.properties

@@ -1,3 +1,2 @@
 android.enableJetifier=true
 android.useAndroidX=true
-android.enableUnitTestBinaryResources=true

gradle/wrapper/gradle-wrapper.properties

@@ -2,4 +2,4 @@ distributionBase=GRADLE_USER_HOME
 distributionPath=wrapper/dists
 zipStoreBase=GRADLE_USER_HOME
 zipStorePath=wrapper/dists
-distributionUrl=https\://services.gradle.org/distributions/gradle-6.0-all.zip
+distributionUrl=https\://services.gradle.org/distributions/gradle-6.1.1-all.zip

translate.py

@@ -5,6 +5,7 @@ import optparse
 import urllib2
 import json
 import base64
+import shutil
 
 parser = optparse.OptionParser()
 parser.add_option("-u", "--user", dest="username", help="transifex user login")
@@ -39,3 +40,8 @@ for language in resource["available_languages"]:
     file = open(filename, "wb")
     file.write(data.read())
     file.close()
+
+filename = path + "values-iw/strings.xml"
+if not os.path.exists(os.path.dirname(filename)):
+    os.makedirs(os.path.dirname(filename))
+shutil.copyfile(path + "values-he/strings.xml", filename)